[Bug 3099] Review request: libbdplus - Open implementation of BD+ protocol

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3099 Simone Caronni <negativo17(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #5 from Simone Caronni <negativo17(a)gmail.com&gt; 2014-01-08 08:54:51 CET --- Couple of fixes... 1) Package should require these, for ldconfig and for installing the directory that contains pkgconfig files. Requires: pkgconfig Requires(post): ldconfig 2) Please remove the "Group" directives since they're not needed since RHEL 5. 3) Please bump libaacs-devel requirements to 0.7.0, it's written in the autotools files. libaacs-devel >= 0.7.0 Apart from these small issues, the package is ok! There are a couple of minor cosmetic changes that you could perform, but these are up to you: -%{_libdir}/pkgconfig/libbdplus.pc +%{_libdir}/pkgconfig/%{name}.pc -make install DESTDIR=$RPM_BUILD_ROOT -find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';' +%make_install +find %{buildroot} -name '*.la' -delete The latter %make_install is the default when creating barebone spec files with rpmdev-newspec. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.