[Bug 1351] Review request: frogatto - An old-school 2D platform game

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1351 Hans de Goede <j.w.r.degoede(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.w.r.degoede(a)gmail.com Blocks|2 |4 AssignedTo|rpmfusion-package- |j.w.r.degoede(a)gmail.com |review(a)rpmfusion.org | --- Comment #13 from Hans de Goede <j.w.r.degoede(a)gmail.com&gt; 2010-09-05 16:24:39 --- Full review done, summary: - rpmlint checks return: frogatto.src: W: spelling-error %description -l en_US gameplay -> game play, game-play, nameplate frogatto.src: W: invalid-license proprietary frogatto.x86_64: W: spelling-error %description -l en_US gameplay -> game play, game-play, nameplate frogatto.x86_64: W: invalid-license proprietary frogatto-debuginfo.x86_64: W: invalid-license proprietary 3 packages and 0 specfiles checked; 0 errors, 5 warnings. Which can all be ignored - package meets naming guidelines - package meets packaging guidelines - license (GPl + proprietary) OK (for non free), text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file included as needed Approved! -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.