[Bug 1742] Review Request: vo-aacenc - VisualOn AAC encoder library

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1742 rc040203(a)freenet.de changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203(a)freenet.de --- Comment #22 from rc040203(a)freenet.de --- (In reply to Hans de Goede from comment #21) - MUSTFIX: Building is non-verbose Please append --disable-silent-rules to %configure - /usr/lib64/pkgconfig/vo-aacenc.pc seems broken to me. It uses includedir=/usr/include, but the headers below /usr/include/vo-aacenc are expecting to find vo-aacenc's headers under /usr/include/vo-aacenc: e.g. /usr/include/vo-aacenc/voAMRWB.h:#include "voAudio.h" i.e. they expect -I/usr/include/vo-aacenc and not -I/usr/include. - Consider to remove the "rm -rf %{buildroot}" from %install It's not needed anymore unless you plan to build this package for really ancient rhels. - Consider to remove the "Group" tags. They aren't used for anything in Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.