[Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #34 from Simone Caronni <negativo17(a)gmail.com> 2013-10-23 16:02:13 CEST
---
Alec Leamas wrote:
"Looks fine. Two more issues:
- In the README.fedora you refer to
http://slaanesh.fedorapeople.org/flash-plugin/README.txt. This doesn't seemt to
exist.
- You run %{_bindir}/update-desktop-database &> /dev/null || : only if [ $1 -eq 0
]. This is not as proposed in the standard packaging scriptlets where it's run
unconditionally [1]. Please fix or justify current code.
[1] http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database
We continue as "normal": : you paste the remarks in the bug....
While you're on it: if other packages pulls systemd, why list systemd-libs?
Thanks, adjusted them all. Systemd-libs is pulled in by mesa and a lot of other
things.
Still at revision 6:
Spec URL: http://slaanesh.fedorapeople.org/steam.spec
SRPM URL: http://slaanesh.fedorapeople.org/steam-1.0.0.43-6.fc19.src.rpm
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.