[Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702 --- Comment #16 from Cédric OLIVIER <cedric.olivier(a)free.fr&gt; 2011-05-01 13:17:06 --- Sorry for delay, as promised you can find my review : [X] rpmlint - OK [X] Name according Naming GuideLines - OK [X] Spec file name - OK [+] Package must meet Packaging Guidelines - OK - [X] Naming - OK - [X] Version, release - OK - [X] Licensing - OK - [X] No inclusion of pre-built binaries or libraries - OK - [X] Spec Legibility - OK - [X] Use rpmlint - OK - [X] Filesystem Layout - OK - [!] Changelogs - (2) - [X] Requires - OK - [X] BuildRequires - OK - [X] Summary and description - OK - [X] Encoding - OK - [X] Documentation - OK - [X] Compiler flags - OK - [X] Debuginfo packages - OK - [NA] Devel Packages - [NA] Shared Libraries - [NA] Packaging Static Libraries - [X] Duplication of system libraries - OK - [NA] Configuration files - [X] Desktop files - OK - [X] Macros - OK - [X] Handling Locale Files - OK - [X] Parallel make - OK - [X] File and Directory Ownership - OK - [!] All patches should have an upstream bug link or comment - (1) - [NA] Man pages - There isn't any arguments to imagination [X] Licensing Guidelines - OK [X] License field - OK [!] Source URL Guidelines - (3) [X] successfully compile - OK [X] Packages must NOT contain any .la - OK [X] Packages containing GUI applications must include a desktop file - OK [X] All filenames in rpm packages must be valid UTF-8 - OK [X] builds in mock - OK (1) - Could you add comments on patch to explain why there are here and if you have information about them by upstream : http://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_hav... (2) - typo error : ')' in last release changelog. And if it's possible, could you add some blank lines between each release for readability ? (3) - could you use name macro as detailed in http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net So there is only cosmetics changes ... -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.