[Bug 3099] Review request: libbdplus - Open implementation of BD+ protocol
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3099
--- Comment #6 from Xavier Bachelot <xavier(a)bachelot.org> 2014-01-08 22:42:02 CET
---
(In reply to comment #5)
Couple of fixes...
1) Package should require these, for ldconfig and for installing the directory
that contains pkgconfig files.
Requires: pkgconfig
Requires(post): ldconfig
/usr/bin/pkg-config is already in the autogenerated Requires, so need to add
the pkgconfig Requires:.
Same for ldconfig, /sbin/ldconfig is in the autogenerated Requires.
2) Please remove the "Group" directives since they're
not needed since RHEL 5.
Done.
3) Please bump libaacs-devel requirements to 0.7.0, it's written
in the
autotools files.
libaacs-devel >= 0.7.0
Done.
Apart from these small issues, the package is ok!
There are a couple of minor cosmetic changes that you could perform, but these
are up to you:
-%{_libdir}/pkgconfig/libbdplus.pc
+%{_libdir}/pkgconfig/%{name}.pc
-make install DESTDIR=$RPM_BUILD_ROOT
-find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'
+%make_install
+find %{buildroot} -name '*.la' -delete
The latter %make_install is the default when creating barebone spec files with
rpmdev-newspec.
ok, changed. I didn't know about %make_install, thanks. It will easily be
confused with %makeinstall though.
Thanks for the review.
Spec : http://www.bachelot.org/fedora/SPECS/libbdplus.spec
SRPM : http://www.bachelot.org/fedora/SRPMS/libbdplus-0.1.0-2.fc20.src.rpm
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.