[Bug 67] Review Request: open-vm-tools - VMware Guest OS Tools

http://bugzilla.rpmfusion.org/show_bug.cgi?id=67 --- Comment #8 from Andrea Musuruane <musuruan(a)gmail.com&gt; 2008-10-27 16:29:27 --- I had another (deeper) look: * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * BuildRequires: desktop-file-utils is missing. * Because of the above it cannot be built in mock. * You should not Require desktop-file-utils to handle the desktop database: https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database * Macro usage can be improved. For example, use %{name} instead of open-vm-tools. * Macro usage is not consistent. Therefore sed instead %{__sed}. * Version in changelog in not coherent. * rpmlint output is not clean. Please run rpmlint with the "-i" parameter for an explanation. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.