10:07 a.m.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2405
Bug #: 2405
Summary: Review Request: ultrastardx - A free OpenSource
karaoke game
Classification: Unclassified
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: puiterwijk(a)gmail.com
CC: rpmfusion-package-review(a)rpmfusion.org
SPEC:
http://puiterwijk.fedorapeople.org/packages/rpmfusion-free/ultrastardx/ul...
SRPM:
http://puiterwijk.fedorapeople.org/packages/rpmfusion-free/ultrastardx/ul...
UltraStar Deluxe is a free OpenSource karaoke game for your PC.
You are able to transform music into karaoke music and play it.
This cannot be included into Fedora because it depends on the ffmpeg library,
which is located in RPMFusion.
rpmlint output:
SPECS/ultrastardx.spec:37: E: hardcoded-library-path in /usr/lib/debug/usr/bin
# This is because this directory is always installed into /usr/lib, no matter
which architecture is built for
SPECS/ultrastardx.spec: W: invalid-url Source0: ultrastardx-svn2904.tar.gz
# This is because it is an SVN checkout
This is my first RPMFusion package, but I am a sponsored Fedora packager.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:07 a.m.
New subject: [Bug 2405] Review Request: ultrastardx - A free OpenSource karaoke game
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2405
Patrick Uiterwijk <puiterwijk(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |2
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:27 p.m.
New subject: [Bug 2405] Review Request: ultrastardx - A free OpenSource karaoke game
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2405
Karel Volný <kvolny(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |kvolny(a)redhat.com
Blocks|2 |3
AssignedTo|rpmfusion-package-review@rp |kvolny(a)redhat.com
|mfusion.org |
--- Comment #1 from Karel Volný <kvolny(a)redhat.com> 2012-08-14 15:27:57 CEST ---
Hi,
a few findings before a full review ...
* note that it'd be nice to package also the data files available to download
* what is the reason to use the svn checkout?
- I know, the release is quite old but were there any changes relevant to linux
that are too hard to backport?
doesn't the upstream plan a fresh release soon?
* when using svn snapshot, please do not use the revision number as a Version
see http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
instead, you should use Release like "1.20120613svn"
* what is the reason to export empty LD_FLAGS?
* debuginfo files should be handled automatically, why to include
"/usr/lib/debug/usr/bin" in %files (which is the source of rpmlint error)?
- and in addition, debuginfos should go into separate package
btw, this dir could be written as %{_prefix}/lib%{_bindir}
* it doesn't build for me ... probably a missing dependency?
...
Compiling lib/ffmpeg/avcodec.pas
Compiling lib/ffmpeg/avutil.pas
Fatal: Can't find unit mathematics used by avutil
Fatal: Compilation aborted
Error: /usr/bin/ppcx64 returned an error exitcode (normal if you did not
specify a source file to be compiled)
make[1]: *** [../game/ultrastardx] Error 1
make[1]: Leaving directory `/home/kvolny/rpmbuild/BUILD/ultrastardx/src'
make: *** [all] Error 2
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:49 p.m.
New subject: [Bug 2405] Review Request: ultrastardx - A free OpenSource karaoke game
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2405
--- Comment #2 from Patrick Uiterwijk <puiterwijk(a)gmail.com> 2012-08-15 01:49:46
CEST ---
* I will look into the data files. I didn't add them because they're a
different source.
* The reason for the svn checkout is because the released version requires too
much changes to be compatible with recent ffmpeg versions: the API for ffmpeg
seems to have changed drastically, which is reflected in the SVN revision.
* The page you linked to also says "and optionally, up to 13 characters (ASCII)
alphanumeric characters that could be useful in finding the revision in the
revision control system.", so it is an option according to the Fedora naming
guidelines, and I like this system because it's clear at once which version I
used for the creation of the SRPM.
* debuginfo will only be handled automatically if they are extracted during RPM
generation (as far as I know), which is not the case: ultrastardx generates
them (always in /usr/lib, as specified in the SPEC) "manually" while building,
thus circumventing the RPM debuginfo extraction.
* The building is indeed broken since a version of ffmpeg that was released
sometime after my review request was posted. I will try to see if a recent
checkout fixes the problem, and else request a new release from upstream.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
11:52 p.m.
New subject: [Bug 2405] Review Request: ultrastardx - A free OpenSource karaoke game
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2405
--- Comment #3 from Patrick Uiterwijk <puiterwijk(a)gmail.com> 2012-08-15 01:52:12
CEST ---
I do, however, agree that I would need to edit the version to match the
guidelines correctly, by putting the svn checkout date and revision id in
Release, and putting Version 1 (for example).
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
9:34 a.m.
New subject: [Bug 2405] Review Request: ultrastardx - A free OpenSource karaoke game
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2405
Karel Volný <kvolny(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
URL| |http://ultrastardx.sourcefo
| |rge.net/
--- Comment #4 from Karel Volný <kvolny(a)redhat.com> 2012-08-15 11:34:06 CEST ---
(In reply to comment #2)
* I will look into the data files. I didn't add them because
they're a
different source.
hm, thinking about it a bit, maybe they'd fit rather in a separate package than
in a subpackage, as the data are not likely to change that often
* The reason for the svn checkout is because the released version
requires too
much changes to be compatible with recent ffmpeg versions: the API for ffmpeg
seems to have changed drastically, which is reflected in the SVN revision.
okay, let's go with a svn snapshot then
* The page you linked to also says "and optionally, up to 13
characters (ASCII)
alphanumeric characters that could be useful in finding the revision in the
revision control system.", so it is an option according to the Fedora naming
guidelines, and I like this system because it's clear at once which version I
used for the creation of the SRPM.
(In reply to comment #3)
I do, however, agree that I would need to edit the version to match
the
guidelines correctly, by putting the svn checkout date and revision id in
Release, and putting Version 1 (for example).
I said "Release like ...", not that you have to use this exact string :-)
it's perfectly okay to put in the svn revision number as long as the whole NVR
can be sorted chronologically (yes, we have the "Epoch" for special cases, but
it is better to avoid it as it is not directly visible to the user)
so, the latest stable version is 1.1 and we can expect the next to be possibly
1.1.1 or 1.2 ... but it is not released yet, and as the code we're going to use
is newer than 1.1 but it will be older then the future 1.x(.y), the
version-release has to fit somewhere in between
(In reply to comment #2)
* debuginfo will only be handled automatically if they are extracted
during RPM
generation (as far as I know), which is not the case: ultrastardx generates
them (always in /usr/lib, as specified in the SPEC) "manually" while building,
thus circumventing the RPM debuginfo extraction.
well, it may be worthy to take a look if this could be disabled, leaving the
work upon rpm
if not, then at least the files should be put into -debuginfo subpackage
manually, as debug files should not be installed by default
* The building is indeed broken since a version of ffmpeg that was
released
sometime after my review request was posted. I will try to see if a recent
checkout fixes the problem, and else request a new release from upstream.
ok; maybe an explicit version dependency should be added then
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
10:10 a.m.
New subject: [Bug 2405] Review Request: ultrastardx - A free OpenSource karaoke
game
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2405
Nicolas Chauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
namespace| |free
Resolution|--- |EXPIRED
--- Comment #5 from Nicolas Chauvet <kwizart(a)gmail.com> ---
A previous package was already in rpmfusion.
I've just retired it since it was not maintained here.
If you want to take-over please use pkgdb.
--
You are receiving this mail because:
You are on the CC list for the bug.
10:30 a.m.
New subject: [Bug 2405] Review Request: ultrastardx - A free OpenSource karaoke
game
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2405
Nicolas Chauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|3 |
Referenced Bugs:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3
[Bug 3] Tracker: Packages under review.
--
You are receiving this mail because:
You are on the CC list for the bug.
2669
days inactive
4549
days old
rpmfusion-developers@lists.rpmfusion.org
7 comments
1 participants
participants (1)
-
RPM Fusion Bugzilla